[PATCHES] ctdb build/packaging

[Amitay Isaacs]

On Fri, Dec 6, 2013 at 5:54 PM, Michael Adam <obnox at samba.org> wrote:

> On 2013-12-06 at 01:49 +0100, Michael Adam wrote:
> > Attached find three patches to ctdb/ in master.
> > - install new manpages
> > - package new manpages
> > - don't run autogen ins spec
> >
> > Comments/review/push appreciated.
> >
> > Cheers - Michael
>
> > From: Michael Adam <obnox at samba.org>
> > Date: Fri, 6 Dec 2013 01:37:34 +0100
> > Subject: [PATCH 3/3] ctdb:packaging:RPM: don't run autogen.
> >
> > This way, we don't have a build dependency on autoconf.
> > Recent changes introduced a dependency into autoconf
> > version >= 2.60, so this fix allows the generated
> > source RPM to be built also on older platforms.
> >
> > Signed-off-by: Michael Adam <obnox at samba.org>
>
> Maybe I should add that the maketarball.sh script
> that creates the tarball for the SRPM already
> runs autogen.sh for us... :-)
>

The CTDB packaging will not work correctly in Samba tree as it depends upon
the availability of correct tags. For building tarballs with correct
version, mkversion.sh script needs to parse VERSION file.

Since the aim is to build/release CTDB as part of Samba, I see no point in
messing with the packaging that was meant for standalone CTDB.  We should
rather focus on waf build script for CTDB.

First two patches are good.  How did I miss packaging new manpages? ;-)

Reviewed-by: Amitay Isaacs <amitay at gmail.com>

Amitay.