[PATCH v2 2/2] torture: match Windows responses to bad shadow copy IDs

Michael Adam obnox at samba.org
Thu Dec 5 14:27:27 MST 2013


pushed to autobuild

(even though the last hunk was still sneaked in.... :-)

Cheers - Michael

On 2013-12-05 at 20:12 +0100, David Disseldorp wrote:
> test_fsrvp_bad_id() issues DeleteShareMapping requests with invalid
> shadow copy IDs, expect Windows Server 2012 return codes.
> 
> Signed-off-by: David Disseldorp <ddiss at samba.org>
> ---
>  source4/torture/rpc/fsrvp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/source4/torture/rpc/fsrvp.c b/source4/torture/rpc/fsrvp.c
> index 48eb509..f853ecf 100644
> --- a/source4/torture/rpc/fsrvp.c
> +++ b/source4/torture/rpc/fsrvp.c
> @@ -415,7 +415,7 @@ static bool test_fsrvp_bad_id(struct torture_context *tctx,
>  	torture_assert_ntstatus_ok(tctx, status,
>  				   "DeleteShareMapping failed");
>  	torture_assert_int_equal(tctx, r_sharemap_del.out.result,
> -				 FSRVP_E_BAD_ID,
> +				 FSRVP_E_OBJECT_NOT_FOUND,
>  				 "incorrect DeleteShareMapping response");
>  
>  	r_sharemap_del.in.ShadowCopySetId = sc_map->ShadowCopySetId;
> @@ -424,7 +424,7 @@ static bool test_fsrvp_bad_id(struct torture_context *tctx,
>  	torture_assert_ntstatus_ok(tctx, status,
>  				   "DeleteShareMapping failed");
>  	torture_assert_int_equal(tctx, r_sharemap_del.out.result,
> -				 FSRVP_E_BAD_ID,
> +				 E_INVALIDARG,
>  				 "incorrect DeleteShareMapping response");
>  
>  	torture_assert(tctx, test_fsrvp_sc_delete(tctx, p, sc_map), "sc del");
> @@ -625,7 +625,7 @@ static bool test_fsrvp_enum_created(struct torture_context *tctx,
>  	return true;
>  }
>  
> -static bool fsrvp_rpc_setup (struct torture_context *tctx, void **data)
> +static bool fsrvp_rpc_setup(struct torture_context *tctx, void **data)
>  {
>  	NTSTATUS status;
>  	struct torture_rpc_tcase *tcase = talloc_get_type(
> -- 
> 1.8.1.4
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131205/84a878b3/attachment.pgp>


More information about the samba-technical mailing list