[PATCH 1/3] test: add fake_snap.pl for snapshot simulation

Andrew Bartlett abartlet at samba.org
Thu Dec 5 13:04:12 MST 2013


On Thu, 2013-12-05 at 17:49 +0100, Michael Adam wrote:
> On 2013-12-05 at 11:05 +0100, David Disseldorp wrote:
> > On Thu, 05 Dec 2013 16:33:08 +1300
> > Andrew Bartlett <abartlet at samba.org> wrote:
> > 
> > > Can we use this to implement tests for the vfs_shadow_copy2 stuff?
> > 
> > Yes, the WIP branch[1] I presented at SambaXP includes selftest changes
> > which expose a snapshottable share using this script.
> > 
> > The FSRVP torture tests then create and remove snapshots, checking to
> > see that previous-file versions are added and removed accordingly.
> > 
> > It's high time I get this stuff in shape for upstream.
> > 
> > Cheers, David
> > 
> > 1. http://git.samba.org/?p=ddiss/samba.git;a=shortlog;h=refs/heads/async_fsrvp_srv_wip_xp2013
> 
> That is very useful, I'll also have a look.
> 
> in my master-shadow_copy2-wip branch, there is a
> started shadow copy torture test (not finished)
> the start of which looks vaguely similar to David's
> fsrvp enum snaps test.
> 
> The idea I had for the shadow_copy2 module test was to manually
> create the snapshots for the test environment with the fake-snap
> script pushed yesterday and then
> only do the snapshot reading ops through the shadow_copy2
> module.
> 
> For this, I have also extended the fakesnap script
> to be able to support more modes that shadow_copy2 knows.
> Needs some polishing though of at least the commit message :)

Thanks.  I had a client ask about this in Samba 4.0 (and have passed on
the commits from master for them to test), and so I was very interested
when I saw that we may be able to get this automatically tested. 

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list