[PATCH 3/3] torture: test duplicate shares in FSRVP shadow-copy set

Michael Adam obnox at samba.org
Wed Dec 4 17:00:28 MST 2013


looks good generally, but:

could it be that these hunks do not really belong to this patch
but should be separate:

On 2013-12-03 at 14:45 +0100, David Disseldorp wrote:
> @@ -402,7 +415,7 @@ static bool test_fsrvp_bad_id(struct torture_context *tctx,
>  	torture_assert_ntstatus_ok(tctx, status,
>  				   "DeleteShareMapping failed");
>  	torture_assert_int_equal(tctx, r_sharemap_del.out.result,
> -				 FSRVP_E_BAD_ID,
> +				 FSRVP_E_OBJECT_NOT_FOUND,
>  				 "incorrect DeleteShareMapping response");
>  
>  	r_sharemap_del.in.ShadowCopySetId = sc_map->ShadowCopySetId;
> @@ -411,7 +424,7 @@ static bool test_fsrvp_bad_id(struct torture_context *tctx,
>  	torture_assert_ntstatus_ok(tctx, status,
>  				   "DeleteShareMapping failed");
>  	torture_assert_int_equal(tctx, r_sharemap_del.out.result,
> -				 FSRVP_E_BAD_ID,
> +				 E_INVALIDARG,
>  				 "incorrect DeleteShareMapping response");
>  
>  	torture_assert(tctx, test_fsrvp_sc_delete(tctx, p, sc_map), "sc del");
> @@ -612,7 +625,7 @@ static bool test_fsrvp_enum_created(struct torture_context *tctx,
>  	return true;
>  }
>  
> -static bool fsrvp_rpc_setup (struct torture_context *tctx, void **data)
> +static bool fsrvp_rpc_setup(struct torture_context *tctx, void **data)
>  {
>  	NTSTATUS status;
>  	struct torture_rpc_tcase *tcase = talloc_get_type(
> -- 
> 1.8.1.4
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131205/40ca9134/attachment.pgp>


More information about the samba-technical mailing list