[PATCH 00/14] Fix several issues pointed out by cppcheck.

Andreas Schneider asn at samba.org
Wed Dec 4 06:01:46 MST 2013


Our internal tools run cppcheck and I got several warnings. Here is a patchset
to address them.

Andreas Schneider (14):
  s4-libcli: Add smb2_util_handle_empty().
  s4-torture: Make sure the handles are not used uninitialized.
  s4-torture: Make sure the handles are initialized correctly.
  s4-torture: Make sure handles are correctly initialized.
  s4-torture: Fix some compile warnings in spoolss.
  s3-torture: Comment out dead code in spoolss test.
  s4-torture: Fix out of bound array access.
  s4-torture: Use talloc for asprintf.
  s3-utils: Fix a memory leak in smbget.
  s3-torture: Fix several memory leaks in delete_fn().
  s3-torture: Make sure status is used initialized.
  s3-libsmb: Fix a memory leak in get_pdc_ip().
  krb5_wrap: Move function declaration outside the function.
  s3-torture: Call cli_flush().

 lib/krb5_wrap/krb5_samba.c        | 17 +++++++++--------
 source3/libsmb/namequery.c        |  1 +
 source3/torture/cmd_vfs.c         |  5 +++--
 source3/torture/nbio.c            |  9 +++++++--
 source3/utils/smbget.c            |  1 +
 source4/libcli/smb2/util.c        |  9 +++++++++
 source4/torture/raw/setfileinfo.c | 22 ++++++++++------------
 source4/torture/rpc/spoolss.c     | 28 ++++++++++++++++++++--------
 source4/torture/rpc/winreg.c      |  5 ++++-
 source4/torture/smb2/streams.c    |  8 +++++++-
 10 files changed, 71 insertions(+), 34 deletions(-)

-- 
1.8.5




More information about the samba-technical mailing list