Patch submission version 4

Jelmer Vernooij jelmer at samba.org
Sun Dec 1 14:08:31 MST 2013


On Mon, Nov 18, 2013 at 01:43:24PM +0100, Stéphane PURNELLE wrote:
> Hi,
> 
> In attached, added test in python test code for testing added 
> functionality in samba-tool

Does "make test" finish succesfully with these changes? This looks
like it is not valid Python code to me:

+        unixhomedir = "\home\"

(since a backslash escapes a quote character, meaning this is an
unterminated string)

Cheers,

Jelmer

> -----------------------------------
> Stéphane PURNELLE                         Admin. Systèmes et Réseaux 
> Service Informatique       Corman S.A.           Tel : 00 32 (0)87/342467
> 
> Andrew Bartlett <abartlet at samba.org> wrote on 11/11/2013 02:51:32:
> 
> > De : Andrew Bartlett <abartlet at samba.org>
> > A : Stéphane PURNELLE <stephane.purnelle at corman.be>, 
> > Cc : samba-technical at samba.org
> > Date : 11/11/2013 02:51
> > Objet : Re: Patch submission version 4
> > 
> > On Wed, 2013-10-09 at 12:20 +0200, Stéphane PURNELLE wrote:
> > > Hi,
> > > 
> > > In attached file, patch in GIT format with some typo correction
> > > 
> > > could you review and push in your master (samba4.1) if ok.
> > 
> > Sorry for the delay in responding, I've been swamped.  We really need
> > tests for additional functionality like this.  Could you add them?
> > 
> > See for example:
> > python/samba/tests/samba_tool/user.py
> > 
> > Andrew Bartlett
> > 
> > -- 
> > Andrew Bartlett
> > http://samba.org/~abartlet/
> > Authentication Developer, Samba Team           http://samba.org
> > Samba Developer, Catalyst IT                   http://catalyst.net.nz
> > 
> > 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20131201/0b97a94d/attachment.pgp>


More information about the samba-technical mailing list