Patch submission version 4

Andrew Bartlett abartlet at
Sun Dec 1 13:51:33 MST 2013

On Wed, 2013-10-09 at 11:35 +0100, Rowland Penny wrote:

> HI, I will say this once again, anything Samba does to the AD database 
> should match what Windows does.
> Windows does NOT add either the 'posixAccount' or 'posixGroup' 
> attributes so Stephanes patch should not add this line:
> +            ldbmessage2["objectClass"] = 
> ldb.MessageElement('posixGroup', ldb.FLAG_MOD_ADD, 'objectClass')
> it should be removing this line:
>               ldbmessage2["objectClass"] = 
> ldb.MessageElement('posixAccount', ldb.FLAG_MOD_ADD, 'objectClass')

For the time-being, I'm going to accept being consistent with the
existing code over making this change to the old code, in a patch series
that is adding new functionality. 

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list