[PATCH] dbwrap_ctdb: Treat empty records as non-existing

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Aug 29 00:09:17 MDT 2013


On Wed, Aug 28, 2013 at 10:50:43PM +0200, Christian Ambach wrote:
> However, around SambaXP I have been testing with some more changes, but
> I do not recall if those are still necessary (and I currently do not
> have the time to test). So would you please have a look at the sharemode
> related pieces in
> https://git.samba.org/?p=ambi/samba.git;a=commitdiff;h=25613e07b5a069d2adbc1eaf3cd311cdb2888869
> to see if those
> 1. make sense

Yes, they do.

> 2. are still necessary?

No, I don't think so. At least in my tests I did not see any
messages. We now hopefully return NT_STATUS_NOT_FOUND
whenever we see an empty record in a ctdb-hosted database.
With that in place we will never hand emtpy TDB_DATA to
parse_share_modes. If we do, I want to see that message, so
that we can fix the remaining spots in dbwrap_ctdb.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

*****************************************************************
visit us on it-sa:IT security exhibitions in Nürnberg, Germany
October 8th - 10th 2013, hall 12, booth 333
free tickets available via code 270691 on: www.it-sa.de/gutschein
******************************************************************


More information about the samba-technical mailing list