Possible NULL-pointer dereference in lib/util/charset/pull_push.c

[Torsten Kurbad]

Hi Jelmer,

On Tue, 27 Aug 2013 21:59:34 +0000, Jelmer Vernooij <jelmer at samba.org>
wrote:
>You don't seem to be passing in workgroup at the moment.

Isn't this done through LoadParm?

See code snippet:

>> lpOptions = dict(
>>     realm = realm,
>>     workgroup = 'KMRC',
>> )
>> 
[...]
>> 
>> 	def __init__(self)
>> 		self._credentials=Credentials()
>> 		self._lp=LoadParm()
>> 
>> 	def connect(self, username, password, realm, url, lpOptions):
[...]
>> 
>> 			for (key, value) in lpOptions.items():
>> 				self._lp.set(key,value)
>> 
>> 			connection = SamDB(url=url,
>> 	                        session_info=self._session_info,
>>         			credentials=self._credentials,
>>                         	lp=self._lp)

Or does SamDB have another parameter for that?

>Of course, this is a bug in the Python bindings somewhere - we
>shouldn't segfault in this situation but raise an exception if a
>domain really is required.

Agreed.

Thanks,
Torsten