[PATCH] Add -e encryption support to SMB3 client protocol support, plus documentation updates.

[Jeremy Allison]

On Tue, Aug 20, 2013 at 03:21:39PM +0200, Michael Adam wrote:
> I am currently reviewing the patchset.
> And it looks good.
> 
> I am only wondering about the (sneaked in) change for thei
> iosize command:

It's not sneaked in :-). It's a change
that metze made in the patchset that
has already gone in, this change just
updates the smbclient command and the
manpage to match the internal functionality.

> Originally 0x400 -- 0xFFFF00 was allowed.
> Now suddenly 0 -- 0xFFFF00 is allowed.
> with 0 meaning server controlled.

That's the way that the internal read/write
code now works.

> Can it be that any x with 0 < x < 0x400
> is mapped to 0x400 (the original minimum)
> implicitly?

Well there's no harm in setting iosize to
1, it'll just be very inefficient. So I
didn't see the need to restrict that.

> And in the manpage, only the SMB1 limit
> is described, not the (lack of) limit in
> the SMB2+ case.

Well setting iosize = 0xFFFF00 (16Mb minus
a bit) is an SMB1 limit, but to really get
the (unlimited) SMB2 size you really need
to set it to zero and let the credit handling
take care of it.

If you can think of better wording I'm happy
to change it :-).

> I'll do more testing and will follow up later..

Thanks !

Jeremy.