[Patch] fix some warnings in ldb

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Aug 16 23:31:35 MDT 2013


On Fri, Aug 16, 2013 at 09:41:07PM -0700, Matthieu Patou wrote:
> On 08/16/2013 05:06 AM, Volker Lendecke wrote:
> >On Thu, Aug 15, 2013 at 11:26:37PM -0700, Matthieu Patou wrote:
> >>Please review & push.
> >Could the first one also be fixed with the attached patch? I
> >don't think the const is strictly required here. I'm taking
> >a look at this code for the first time how, so it might be
> >perfectly possible that I'm missing something. But I think
> >if we can avoid a discard_const, we should do so.
> >
> >Volker
> >
> I think it's ok but as there is more or less a dickat on not
> changing existing API for ldb I was not keen on changing the
> signature even thought it's only from const to non const, also I
> have to check that now it didn't generate more warnings for callers
> as if we pass const variable it will then generate a warning
> elsewhere.

According to git grep, there were only two callers. One put
in NULL, the other a non-const. This seems to be a pretty
internal call.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list