[PATCH} Implement SMB3/SMB3 in smbclient and smbcacls (and generic client library).

Michael Adam obnox at samba.org
Thu Aug 15 01:40:09 MDT 2013


Jeremy and Metze,

This is great stuff, indeed!!

Cheers - Michael

On 2013-08-15 at 09:02 +0200, Stefan (metze) Metzmacher wrote:
> Am 15.08.2013 00:39, schrieb Jeremy Allison:
> > On Wed, Aug 14, 2013 at 09:34:31PM +0200, Stefan (metze) Metzmacher wrote:
> >>
> >> I've tested the current patchset with LANMAN2, NT1, SMB2_02, SMB2_10 and
> >> SMB3 against
> >> a w2012 server with the en_windows_server_2012_x64_dvd_915478.iso file.
> >> (I'm getting an error in the LANMAN1 tree_connect_andx request, using an
> >> old tree_connect
> >>  works there too, but I'll leave the fix for that for another day...)
> >> I've tested it with the defeault window size (16MByte) and with
> >> 512MByte, but there
> >> doesn't seem to be a win with a larger size.
> >>
> >> Everything seems to work fine and it passed autobuild 3 times...
> >>
> >> Please go through the commits and re-add your sign-off to commits I've
> >> modified
> >> and the review to the others, if you're also happy with it.
> > 
> > Ok, here is Metze's modified patch with my Reviewed-by's added
> > (attached as a .gz patchset).
> > 
> > There's only one extra change I added, and that's is to
> > add in the plumbing for adding cli_smb2_getatr() inside cli_getatr(),
> > which I missed initially (and without it doing smbclient setmode calls
> > fail over SMB2/SMB3, which is a shame as everything else works so
> > nicely :-).
> 
> Thanks, pushed to autobuild.
> 
> metze
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 215 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130815/2b268f10/attachment.pgp>


More information about the samba-technical mailing list