[PATCH} Implement SMB3/SMB3 in smbclient and smbcacls (and generic client library).

Jeremy Allison jra at samba.org
Wed Aug 14 16:39:31 MDT 2013


On Wed, Aug 14, 2013 at 09:34:31PM +0200, Stefan (metze) Metzmacher wrote:
> 
> I've tested the current patchset with LANMAN2, NT1, SMB2_02, SMB2_10 and
> SMB3 against
> a w2012 server with the en_windows_server_2012_x64_dvd_915478.iso file.
> (I'm getting an error in the LANMAN1 tree_connect_andx request, using an
> old tree_connect
>  works there too, but I'll leave the fix for that for another day...)
> I've tested it with the defeault window size (16MByte) and with
> 512MByte, but there
> doesn't seem to be a win with a larger size.
> 
> Everything seems to work fine and it passed autobuild 3 times...
> 
> Please go through the commits and re-add your sign-off to commits I've
> modified
> and the review to the others, if you're also happy with it.

Ok, here is Metze's modified patch with my Reviewed-by's added
(attached as a .gz patchset).

There's only one extra change I added, and that's is to
add in the plumbing for adding cli_smb2_getatr() inside cli_getatr(),
which I missed initially (and without it doing smbclient setmode calls
fail over SMB2/SMB3, which is a shame as everything else works so
nicely :-).

It's completely boilerplate (and identical to the other
patches plumbing smb2 calls inside the smb client libraries)
however it does need an additional Team member review before
I'm happy to push the complete set, and Metze is now on vacation :-).

So can I have a +1 on the 0001-s3-libsmb-Plumb-cli_smb2_getatr-inside-cli_getatr.patch
attachment from a Team member please, and I'll finally get
all the SMB2 client code working for 4.1.0 !

Cheers,

	Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smb2-client.patchset.gz
Type: application/octet-stream
Size: 34523 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130814/66861d68/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-libsmb-Plumb-cli_smb2_getatr-inside-cli_getatr.patch
Type: text/x-diff
Size: 1121 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130814/66861d68/attachment.patch>


More information about the samba-technical mailing list