[PATCH} Implement SMB3/SMB3 in smbclient and smbcacls (and generic client library).

[Jeremy Allison]

On Wed, Aug 14, 2013 at 09:34:31PM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> 
> >> Especially as with your new code reading files
> >> is now broken :-(. Example with my test file of
> >> 3695179776 byes against Windows Server 2012:
> >>
> >> bin/smbclient //172.27.69.20/temp -mSMB3  --send-buffer=0
> >> Domain=[WIN-4QBFHKK7F2P] OS=[] Server=[]
> >> smb: \> get en_windows_server_2012_x64_dvd_915478.iso 
> >> parallel_read returned NT_STATUS_CONNECTION_DISCONNECTED
> >>
> >> Which didn't happen with the earlier change (without
> >> the re-written cli_pull()/push()).
> >>
> >> Yes I know this is just a bug with the new cli_pull/push
> >> code (which we'll have to track down and fix) but
> >> wouldn't it be easier to have working SMB2 read/write,
> >> then debug the changed cli_pull/push code afterwards ?
> 
> The problem is that I think it just works because it doesn't max out
> the credits, but would fail against a busy server, which slows
> us down.
> 
> Also adding smb2cli_conn_available_credits() and the related
> cli_read_max_bufsize() change and directly reverting them in the same
> patchset seems a bit strange.
> 
> > I'm pretty sure this is us running out of credits.
> > Usually that's what causes the server to send a
> > FIN back.
> 
> Yes, it was a generic credit problem which had nothing to do with my
> changes.
> 
> See
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=080f8bcb2b91ae1f09d06ba219567a7f6f1a1605

Dammit, I was trying to find that off-by-one issue all morning :-).

Thanks for tracking it down !

Cheers,

	Jeremy.