[PATCH] libctdb: Avoid an explicit memset

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Aug 14 05:55:04 MDT 2013


Hi!

This does save some bytes with -O3.

Please review&push.

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From eba6b60a0fe742e6d9ed23f2e6e4a4f1651cb57a Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 13 Aug 2013 10:50:15 +0000
Subject: [PATCH] libctdb: Avoid an explicit memset

Give the compiler a chance to use better code. Saves a few bytes of text.

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/lib/ctdbd_conn.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c
index 1481a9c..4f5dce0 100644
--- a/source3/lib/ctdbd_conn.c
+++ b/source3/lib/ctdbd_conn.c
@@ -201,7 +201,7 @@ static NTSTATUS ctdbd_connect(TALLOC_CTX *mem_ctx,
 {
 	struct ctdb_packet_context *result;
 	const char *sockname = lp_ctdbd_socket();
-	struct sockaddr_un addr;
+	struct sockaddr_un addr = { 0, };
 	int fd;
 	socklen_t salen;
 
@@ -211,7 +211,6 @@ static NTSTATUS ctdbd_connect(TALLOC_CTX *mem_ctx,
 		return map_nt_error_from_unix(errno);
 	}
 
-	ZERO_STRUCT(addr);
 	addr.sun_family = AF_UNIX;
 	snprintf(addr.sun_path, sizeof(addr.sun_path), "%s", sockname);
 
-- 
1.8.1.2



More information about the samba-technical mailing list