[PATCH} Implement SMB3/SMB3 in smbclient and smbcacls (and generic client library).

Jeremy Allison jra at samba.org
Tue Aug 13 12:09:27 MDT 2013


On Tue, Aug 13, 2013 at 07:27:43PM +0200, Stefan (metze) Metzmacher wrote:
> > 
> > Here's my current patchset (from my master3-jra branch)
> > 
> > I've rewritten cli_pull/push to dynamically use up to 256 requests.
> > The complete set compiles for me, but I haven't done any testing yet.
> > (I'm compile each commit later...)
> > 
> > I've marked the commits I've done completely new as "TODO testing ..."
> > and some should be reviewed again by you and one maybe squashed after
> > your review.
> 
> I've tested put and get with a 35M file
> 
> There was a next = chunk; instead of next = chunk->next; ...

Just a quick comment. Should we just add in the working
fix first, then add in the cli_pull()/push() afterwards ?

That way we're not mixing the functionality changes up.

Jeremy.


More information about the samba-technical mailing list