[PATCH] s3-winbind: Try lsa connect over np if tcpip fails.

[Stefan (metze) Metzmacher]

Am 13.08.2013 19:36, schrieb Jeremy Allison:
> On Tue, Aug 13, 2013 at 09:41:31AM -0700, Christof Schmitt wrote:
>> On Tue, Aug 13, 2013 at 02:00:00PM +0200, Andreas Schneider wrote:
>>> BUG: https://bugzilla.samba.org/show_bug.cgi?id=9615
>>> BUG: https://bugzilla.samba.org/show_bug.cgi?id=9899
>>>
>>> Signed-off-by: Andreas Schneider <asn at samba.org>
>>> ---
>>>  source3/winbindd/winbindd_cm.c | 5 ++---
>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
>>> index 6c3f6ea..e6b6822 100644
>>> --- a/source3/winbindd/winbindd_cm.c
>>> +++ b/source3/winbindd/winbindd_cm.c
>>> @@ -2642,11 +2642,10 @@ NTSTATUS cm_connect_lsat(struct winbindd_domain *domain,
>>>  			invalidate_cm_connection(&domain->conn);
>>>  			status = cm_connect_lsa_tcp(domain, mem_ctx, cli);
>>>  		}
>>> -		if (!NT_STATUS_IS_OK(status)) {
>>> +		if (NT_STATUS_IS_OK(status)) {
>>>  			return status;
>>>  		}
>>> -
>>> -		return NT_STATUS_OK;
>>> +		domain->can_do_ncacn_ip_tcp = false;
>>>  	}
>>>
>>>  	status = cm_connect_lsa(domain, mem_ctx, cli, lsa_policy);
>>> -- 
>>> 1.8.3.1
>>>
>>
>> I just tested the patch. It fixes the problem pointed out in
>> https://bugzilla.samba.org/show_bug.cgi?id=9899#c9
> 
> Yeah, looks similar to the patch written by florianriehm at web.de.
> 
> What I don't understand is why the TCP connection fails, but
> the RPC over NBT works.

for tcp we require schannel which only works against a direct trust.

I've pushed this to autobuild (GD did the same patch...)

https://gitweb.samba.org/?p=metze/samba-autobuild/.git;a=commitdiff;h=b0850f5887c75851fdcda63adb526560ace2d0b0

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130813/0673d49b/attachment.pgp>