[PATCH] vfs_glusterfs: Make sure posix acls are formatted "before setting"/"after getting"

[Raghavendra Talur]

Simo, Andrew, Jeremy and Chris,

Thank you all for the feedback. I apologize for not replying
earlier, I was on a vacation.

1. I agree with the formatting changes.
2. When I first read the plugin code I had the same questions as
   Jeremy has, but, when I looked at the libacl code:

   a. http://acl.sourcearchive.com/documentation/2.2.49-1/____acl__from__xattr_8c-source.html
   b. http://acl.sourcearchive.com/documentation/2.2.49-1/acl__ea_8h-source.html

   I was convinced that this was a acceptable way of handling acls. As the plugin interacts
   only with Samba on one side and libgfapi of Gluster on the other, both residing on the
   same machine, I could not think of any case where plugin would need to handle anything
   extra than what libacl does.

Not to undermine any of the reviews, I am asking this just to make it clear to any new
person who would ask the same question of "why din't we do what libacl does?"

Thanks! 
Raghavendra Talur | Red Hat Storage Developer | Bangalore | +918039245176 

----- Original Message -----
From: "Christopher R. Hertel" <crh at samba.org>
To: "Raghavendra Talur" <rtalur at redhat.com>
Cc: avati at redhat.com, samba-technical at lists.samba.org, jarrpa at redhat.com
Sent: Saturday, August 10, 2013 8:54:44 AM
Subject: Re: [PATCH] vfs_glusterfs: Make sure posix acls are formatted "before setting"/"after getting"

Simo, Andrew, Jeremy,

Thanks for the feedback.

Talur:  Please follow the thread and review the comments, particularly
        Jeremy's concerns about portability.

Chris -)-----

-- 
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org