[PATCH] regshell.c: fix a bug of predef

Jelmer Vernooij jelmer at samba.org
Tue Aug 6 20:10:31 MDT 2013


On Wed, Aug 07, 2013 at 10:05:35AM +0800, Peng Haitao wrote:
> 
> On 08/07/2013 09:47 AM, Jelmer Vernooij wrote:
> >> -	{"predef", "predefined", "Go to predefined key", cmd_predef },
> >> +	{"predef", "ch", "Go to predefined key", cmd_predef },
> >>  	{NULL }
> >>  };
> > I think the manpage should be considered outdated in this case. It
> > probably wasn't updated after we changed regshell.c.
> > 
> > "ch" refers to "change hive". A predefined key sometimes, but not
> > always, refers to a hive.
> "ch" may be not good, but I think "ch" is better than "predefined" as alias of "predef".
> Thanks.
"predefined" is the full name of the command, "predef" the abbreviated
version.

"ch" is wrong and confusing since this command doesn't necessarily change to a
different hive - a predefined key and a hive are different things.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130807/80b24bec/attachment.pgp>


More information about the samba-technical mailing list