[PATCH] net.c: fix a bug of -n

[Jelmer Vernooij]

On Wed, Aug 07, 2013 at 09:21:37AM +0800, Peng Haitao wrote:
> 'myname' should be replaced with 'netbiosname' according to manpage.
> 
> Signed-off-by: Peng Haitao <penght at cn.fujitsu.com>
> ---
>  source3/utils/net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/utils/net.c b/source3/utils/net.c
> index 3473641..b0fb287 100644
> --- a/source3/utils/net.c
> +++ b/source3/utils/net.c
> @@ -779,7 +779,7 @@ static struct functable net_func[] = {
>  		{"user",	'U', POPT_ARG_STRING, &c->opt_user_name, 'U'},
>  		{"ipaddress",	'I', POPT_ARG_STRING, 0,'I'},
>  		{"port",	'p', POPT_ARG_INT,    &c->opt_port},
> -		{"myname",	'n', POPT_ARG_STRING, &c->opt_requester_name},
> +		{"netbiosname",	'n', POPT_ARG_STRING, &c->opt_requester_name},
>  		{"server",	'S', POPT_ARG_STRING, &c->opt_host},
>  		{"encrypt",	'e', POPT_ARG_NONE,   NULL, 'e', N_("Encrypt SMB transport (UNIX extended servers only)") },
>  		{"container",	'c', POPT_ARG_STRING, &c->opt_container},
Thanks for the patches.

I also think we should fix the docs in this case; they were probably
just copied over from the manpage for another utility.

If we want to rename this argument (it would be good for consistency)
then it should happen in a backwards-compatible manner that won't
break existing users of the current argument name.

Cheers,

Jelmer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130807/17db5aa4/attachment.pgp>