[PATCH]vfs_glusterfs : Volume capacity reported to Windows is incorrect

Jeremy Allison jra at samba.org
Tue Aug 6 15:46:10 MDT 2013


On Mon, Aug 05, 2013 at 02:58:59PM +0530, Susant Kumar Palai wrote:
> 
> VFS plugin was sending the actual size of the volume instead of the
> total number of block units because of which windows was getting the
> wrong volume capacity.
> 
> Signed-off-by: susant <spalai at redhat.com>
> ---
>   src/vfs_glusterfs.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/vfs_glusterfs.c b/src/vfs_glusterfs.c
> index aa07733..444100b 100644
> --- a/src/vfs_glusterfs.c
> +++ b/src/vfs_glusterfs.c
> @@ -307,16 +307,16 @@ vfs_gluster_disk_free(struct vfs_handle_struct
> *handle, const char *path,
>                  return -1;
>          }
> 
> -       dfree = statvfs.f_bsize * statvfs.f_bavail;
> +       dfree = statvfs.f_bavail;
> 
>          if (bsize_p) {
> -               *bsize_p = statvfs.f_bsize;
> +               *bsize_p = statvfs.f_bsize; /*Block size*/
>          }
>          if (dfree_p) {
> -               *dfree_p = dfree;
> +               *dfree_p = dfree; /*Available Block units*/
>          }
>          if (dsize_p) {
> -               *dsize_p = statvfs.f_bsize * statvfs.f_blocks;
> +               *dsize_p = statvfs.f_blocks; /*Total Block units*/
>          }
> 
>          return dfree;
> -- 
> 1.7.1

This patch doesn't apply in the Samba tree. I think the following
is what you want. Please confirm (and I'm +1 on the review
if so).

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-VFS-plugin-was-sending-the-actual-size-of-the-volume.patch
Type: text/x-diff
Size: 1651 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130806/9e2a0086/attachment.patch>


More information about the samba-technical mailing list