[PATCH]: NetShareEnum - Removing a loop around smbXsrv_tcon_global.tdb traversal

[Shekhar Amlekar]

Hi Jeremy,

Yes, this looks good ; thanks for the review!

regards,
shekhar.



From:   Jeremy Allison <jra at samba.org>
To:     Shekhar Amlekar/India/IBM at IBMIN, 
Cc:     samba-technical at lists.samba.org
Date:   08/06/2013 04:05 AM
Subject:        Re: [PATCH]: NetShareEnum - Removing a loop around 
smbXsrv_tcon_global.tdb traversal



On Mon, Jul 22, 2013 at 07:46:50PM +0530, Shekhar Amlekar wrote:
> Hi,
> 
> Please find attached a patch that removes a loop around the traversal of 

> smbXsrv_tcon_global.tdb in the NetShareEnum call.
> Request your review.

I'd prefer modifying this patch to move the enumeration
functions into source3/rpc_server/srvsvc/srv_srvsvc_nt.c
rather than adding them into source3/smbd/connections.c

Here's a modified version that does that. Can you confirm
you're happy with it ? If so I'll add my +1 review and
propose it for master.

Cheers,

                 Jeremy
[attachment 
"0001-s3-smbd-connection-added-routines-to-compute-share-c.patch" deleted 
by Shekhar Amlekar/India/IBM]