[PATCH]: NetShareEnum - Removing a loop around smbXsrv_tcon_global.tdb traversal

Jeremy Allison jra at samba.org
Mon Aug 5 16:36:17 MDT 2013


On Mon, Jul 22, 2013 at 07:46:50PM +0530, Shekhar Amlekar wrote:
> Hi,
> 
> Please find attached a patch that removes a loop around the traversal of 
> smbXsrv_tcon_global.tdb in the NetShareEnum call.
> Request your review.

I'd prefer modifying this patch to move the enumeration
functions into source3/rpc_server/srvsvc/srv_srvsvc_nt.c
rather than adding them into source3/smbd/connections.c

Here's a modified version that does that. Can you confirm
you're happy with it ? If so I'll add my +1 review and
propose it for master.

Cheers,

	Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-connection-added-routines-to-compute-share-c.patch
Type: text/x-diff
Size: 3182 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130805/e2e4801f/attachment.patch>


More information about the samba-technical mailing list