review of my master4-schannel-base branch

[Andrew Bartlett]

On Mon, 2013-08-05 at 07:38 +0200, Stefan (metze) Metzmacher wrote:
> Am 05.08.2013 06:43, schrieb Andrew Bartlett:
> > On Sat, 2013-08-03 at 09:22 +0200, Stefan (metze) Metzmacher wrote:
> >> Hi Günther,
> >>
> >> can you please add the missing reviews to my
> >> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-schannel-base
> >> branch and push it to master?
> >>
> >> Andreas, I've cc'ed you to look at
> >> https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=c78ec1f7fce098a2da4ee839ca321ccab4c2d584
> >>
> >> But you can also review the rest and push it if you want.
> > 
> > Wow!  There is a lot of work in there!
> > 
> > I've seen this kicking around in your git repo for a number of months,
> > it's great to see this finally ready for merging.
> 
> The real work is still pending in
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-schannel
> but I try to bring some patches upstream...

Thanks.  Let me know if I can help with this in any way.

> I'll also try to fix the problem that we may need to use the old machine
> password
> against a domain controller that doesn't have our new password yet.
> And related problems with multiple winbindd processes changing the
> machine password
> at the same time on different cluster nodes.
> 
> If you want you could review and push the cli_credential related changes
> in
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-tmp5

Done!

(And let me know if you have any other branches I can push)

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz