tevent_loop_wait() never finishes

[Andreas Schneider]

On Thursday 01 August 2013 09:08:58 Stefan  Metzmacher wrote:
> Am 31.07.2013 21:39, schrieb Stefan (metze) Metzmacher:
> > Hi Volker,
> > 
> >> On Mon, Jun 24, 2013 at 02:52:05PM +0200, Pavel Březina wrote:
> >>> Hi,
> >>> I've run across a problem where I don't have any custom event
> >>> handlers registered with tevent, but the program gets stuck in
> >>> tevent_loop_wait().
> >> 
> >> Does the attached (untested!) patch fix it?
> > 
> > Thanks, this looks good to me, this also fixes an 2 fd leaks...
> 
> Ok, I looked at it more detailed and there's no fd leak
> as tevent_common_context_destructor() closes the pipe.
> 
> But as the current code never sets
> ev->pipe_fds[0] = -1; ev->pipe_fds[1] = -1;
> 
> I haad to update the patch, otherwise we'd potentially call
> close(0);
> 
> Volker, is it ok to add your sign-off?
> Andreas, is it ok to add your reviewed-by?

Discussed on IRC. Patch looks good!

+1

	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org