tevent_loop_wait() never finishes

[Stefan (metze) Metzmacher]

Am 31.07.2013 21:39, schrieb Stefan (metze) Metzmacher:
> Hi Volker,
> 
>> On Mon, Jun 24, 2013 at 02:52:05PM +0200, Pavel Březina wrote:
>>> Hi,
>>> I've run across a problem where I don't have any custom event
>>> handlers registered with tevent, but the program gets stuck in
>>> tevent_loop_wait().
>>
>> Does the attached (untested!) patch fix it?
> 
> Thanks, this looks good to me, this also fixes an 2 fd leaks...

Ok, I looked at it more detailed and there's no fd leak
as tevent_common_context_destructor() closes the pipe.

But as the current code never sets
ev->pipe_fds[0] = -1; ev->pipe_fds[1] = -1;

I haad to update the patch, otherwise we'd potentially call
close(0);

Volker, is it ok to add your sign-off?
Andreas, is it ok to add your reviewed-by?

metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 1318 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130801/c1a1010f/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130801/c1a1010f/attachment.pgp>