[PATCH] idl: use logical dcerpc_object ordering

Stefan (metze) Metzmacher metze at samba.org
Tue Apr 30 00:20:39 MDT 2013

Hi David,

>> I'm wondering why I didn't see problems with this on the wire while
>> testing PDUs with object...
> The ordering shouldn't be causing any object (un)marshalling issues, as
> the C-compiler starts execution at the case that matches the expression
> value - (K&R says cases and the default clause can occur in any order).


>> Shouldn't we better fix or reject this at the pidl layer?
> Given the change is cosmetic only, I don't think that it's worth it.
> That said, feel free to push the attached patch along-side if you
> prefer.

I think we should do nothing at all:-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130430/b2934a35/attachment.pgp>

More information about the samba-technical mailing list