[PATCH] idl: use logical dcerpc_object ordering

David Disseldorp ddiss at suse.de
Mon Apr 29 11:34:52 MDT 2013

Hi Metze,

On Mon, 29 Apr 2013 18:57:30 +0200
"Stefan (metze) Metzmacher" <metze at samba.org> wrote:

> Hi David,
> I'm wondering why I didn't see problems with this on the wire while
> testing PDUs with object...

The ordering shouldn't be causing any object (un)marshalling issues, as
the C-compiler starts execution at the case that matches the expression
value - (K&R says cases and the default clause can occur in any order).

> Shouldn't we better fix or reject this at the pidl layer?

Given the change is cosmetic only, I don't think that it's worth it.
That said, feel free to push the attached patch along-side if you

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pidl-die-if-switch_is-defaults-are-before-case-entri.patch
Type: text/x-patch
Size: 850 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130429/51007380/attachment.bin>

More information about the samba-technical mailing list