[PATCH] Add tests for our NFSv4 ACL code
abartlet at samba.org
Sun Apr 28 16:11:42 MDT 2013
On Sun, 2013-04-28 at 22:38 +0200, Alexander Werth wrote:
> On Fri, 2013-04-26 at 19:10 +0200, Christian Ambach wrote:
> > On 04/26/2013 02:04 PM, Andrew Bartlett wrote:
> > > I've updated that branch, as I found I made similar errors in the ZFS
> > > code as I did in the GPFS code. Make sure you grab the more recent
> > > code.
> > AIX reports some errors as well:
> > "../source3/modules/vfs_aixacl2.c", line 213.10: 1506-045 (S) Undeclared
> > identifier ppdesc.
> > "../source3/modules/vfs_aixacl2.c", line 305.37: 1506-098 (E) Missing
> > argument(s).
> > "../source3/modules/vfs_aixacl2.c", line 423.20: 1506-280 (W) Function
> > argument assignment between types "char*" and "struct smb_filename*" is
> > not allowed.
> > "../source3/modules/vfs_aixacl2.c", line 535.30: 1506-196 (W)
> > Initialization between types "struct smb_acl_t*(*)(struct
> > vfs_handle_struct*,struct files_struct*,void*)" and "struct
> > smb_acl_t*(*)(struct vfs_handle_struct*,struct files_struct*)" is not
> > allowed.
> > Do you want to fix them? I can do that, too.. but not before next week.
> > Christian
> These bugs are actually all already in samba 4.0 master and they are not
> introduced by this patchset.
Yep. They are fixed in my nfsv4-2 branch however (the first commit),
except for the ppdesc error, which I can't make sense of.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical