[PATCH] Add tests for our NFSv4 ACL code

Andrew Bartlett abartlet at samba.org
Fri Apr 26 16:28:23 MDT 2013

On Fri, 2013-04-26 at 19:10 +0200, Christian Ambach wrote:
> On 04/26/2013 02:04 PM, Andrew Bartlett wrote:
> > I've updated that branch, as I found I made similar errors in the ZFS
> > code as I did in the GPFS code.  Make sure you grab the more recent
> > code.
> AIX reports some errors as well:
> "../source3/modules/vfs_aixacl2.c", line 213.10: 1506-045 (S) Undeclared 
> identifier ppdesc.
> "../source3/modules/vfs_aixacl2.c", line 305.37: 1506-098 (E) Missing 
> argument(s).
> "../source3/modules/vfs_aixacl2.c", line 423.20: 1506-280 (W) Function 
> argument assignment between types "char*" and "struct smb_filename*" is 
> not allowed.
> "../source3/modules/vfs_aixacl2.c", line 535.30: 1506-196 (W) 
> Initialization between types "struct smb_acl_t*(*)(struct 
> vfs_handle_struct*,struct files_struct*,void*)" and "struct 
> smb_acl_t*(*)(struct vfs_handle_struct*,struct files_struct*)" is not 
> allowed.
> Do you want to fix them? I can do that, too.. but not before next week.

I think I've fixed those up, as well as the ZFS issues that I missed
last night, but please continue to look over these carefully. 

I'll get to testing these today.


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list