[PATCH 2/2, RESEND] source4/libcli: Only set ctemp set on success

Jeremy Allison jra at samba.org
Tue Apr 23 14:53:38 MDT 2013


On Tue, Apr 23, 2013 at 09:27:50AM +0200, Volker Lendecke wrote:
> On Mon, Apr 22, 2013 at 10:23:16AM -0500, samlang at gmail.com wrote:
> > From: Sam Lang <sam.lang at inktank.com>
> > 
> > If open fails ctemp.out.name probably won't be valid and strdup
> > will cause a segv.  Only set the path if open succeeds.
> > 
> > Signed-off-by: Sam Lang <sam.lang at inktank.com>
> 
> Reviewed-by: Volker Lendecke <vl at samba.org>
> 
> Please another team member also review this and if it is
> okay and someone has the time please push.

I'll take care of that. FYI - I visited Red Hat
today and we should have a Gluster module ready
for integration very soon.

I think there's some issues here I'd like to
talk with the Inktank developers about, but
that can wait until we've got the first version
integrated.

Cheers,

	Jeremy.


More information about the samba-technical mailing list