[PATCH] smb2 : FSCTL_PIPE_WAIT support

[Volker Lendecke]

On Sun, Apr 21, 2013 at 01:15:51PM +0200, Jean-Daniel FISCHER wrote:
> Hi everyone,
> 
> I joined to this email a simple patch that add support for PIPE_WAIT
> message. This is required for WSP future implementation.

A few comments:

Please no C++ // comments
Please no lines longer than 80 chars
Please no variable declarations after code

That's all in README.Coding

Then,

+           int index = 0;
+           for (index = 0; index < nameLength; index = index + 2)
+           {
+               named_pipe_name[index/2] = named_pipe_name[index];
+           }
+           named_pipe_name[nameLength/2] = '\0';

looks like you want to convert UCS2 to ASCII. We have
convert_string_talloc & friends for this.

Then, it would be great if you could do a "git format-patch"
style patch. That makes it much easier to apply and test
locally.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de