Some comments about the Synology version of Samba

[Richard Sharpe]

On Fri, Apr 19, 2013 at 6:40 PM, Richard Sharpe
<realrichardsharpe at gmail.com> wrote:
> Out of curiosity I downloaded the synology source code from here:
> http://sourceforge.net/projects/dsgpl/files/Synology%20NAS%20GPL%20Source/3201branch/synogpl-3201-x64.tbz/download
>
> The Samba code consists the Samba source as modified by Synology.
> There are no patches that I can find.
>
> There are 146 modified files.
>
> Modifications are surounded with #ifdef MY_ABC_HERE or #ifndef
> MY_ABC_HERE. Weird symbols.
>
> More when I get a better look at the differences.

This one is just plain ugly:

@@ -662,7 +723,14 @@
 #ifdef HAVE_KRB5
        if (kerb_mech && ((lp_security()==SEC_ADS) ||
                                USE_KERBEROS_KEYTAB) ) {
+               SYNOSMB_LOG(3, "use krb5");
                bool destroy_vuid = True;
+#ifdef MY_ABC_HERE
+               /* Only kerberos need sync time */
+               if (lp_syno_sync_dctime()) {
+                       system("/usr/syno/bin/synosyncdctime > /dev/null 2>&1");
+               }
+#endif

Why not run a daemon that syncs the time every minute?
-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)