[PATCH 1/2] s3/modules: New vfs module: cephfs

Jeremy Allison jra at samba.org
Fri Apr 19 14:56:48 MDT 2013


On Fri, Apr 19, 2013 at 02:55:40PM -0500, Sam Lang wrote:
> 
> The warnings with printf are platform specific (unsigned long must not
> be 64 bits on your system).

Yes, I think I'm on a 32-bit ubuntu build.

>  The standard way to resolve this is samba
> is to cast?  Down to a 32-bit int?  Is using PRIu64 a viable option in
> samba code?

Well when you get this error :

‘%lu’ expects argument of type ‘long
+unsigned int’, but argument 2 has type ‘uint64_t’ [-Werror=format]

if you know you want to print a 64-bit value then
change the printf format type to '%llu' and cast
to (unsigned long long) as we know that'll be 64-bit.

>  plus you'll need to use smb_strdup()
> > not strdup()) then resubmit ?
> 
> Yep.  Not sure why doesn't throw an error on my build...

Yeah, that's an old paranoia warning we might
not need anymore but it's easy to use the samba
supplied function.

Jeremy.


More information about the samba-technical mailing list