[PATCH] Fix bug 9811 - Old DOS SMB CTEMP request uses a non-VFS function to access the filesystem.

David Disseldorp ddiss at suse.de
Fri Apr 19 03:19:00 MDT 2013


On Fri, 19 Apr 2013 11:01:54 +0200
Andreas Schneider <asn at samba.org> wrote:

> +	char *wire_name = NULL;
> 
> ...
> 
> +	for (i = 0; i < 10; i++) {
> +		if (*wire_name) {
> 
> As wire_name can be NULL the if check should look like this:
> 
> if (wire_name != NULL && wire_name[0] != '\0')

I don't think that's needed, srvstr_get_path_req() always allocates on
success.

Cheers, David


More information about the samba-technical mailing list