[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Thu Apr 18 15:50:55 MDT 2013


On Thu, Apr 18, 2013 at 11:48:16PM +0200, Michael Adam wrote:
> Hi Jeremy,
> 
> On 2013-04-18 at 11:51 -0700, Jeremy Allison wrote:
> > On Thu, Apr 18, 2013 at 03:11:03PM +0200, Michael Adam wrote:
> > > The branch, master has been updated
> > 
> > >        via  1ed22ba s3:smbd: add a scavenger process for disconnected durable handles
> > 
> > FYI:
> > 
> > [2825/4006] Compiling source3/smbd/scavenger.c
> > ../source3/smbd/scavenger.c: In function ‘scavenger_timer’:
> > ../source3/smbd/scavenger.c:482:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ [-Werror=format]
> > ../source3/smbd/scavenger.c:490:3: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ [-Werror=format]
> > cc1: some warnings being treated as errors
> > Waf: Leaving directory `/home/jeremy/src/samba/git/review/bin'
> > Build failed:  -> task failed (err #1): 
> > 	{task: cc scavenger.c -> scavenger_91.o}
> > make: *** [all] Error 1
> 
> Gosh, sorry for missing that!
> 
> > Please fix this asap.
> 
> proposed fix attached for review.
> 
> > Next time please pass these patches through samba-technical
> > so others can have a chance to review & test.
> 
> Got you... :-)
> 
> Cheers - Michael

LGTM. Pushed - thanks !


More information about the samba-technical mailing list