[PATCH] Add tests for our NFSv4 ACL code

Alexander Werth werth at linux.vnet.ibm.com
Mon Apr 15 10:24:23 MDT 2013


That very similar to what I'm working on.
At least I was on the right track.

On Sun, 2013-04-14 at 22:00 +1000, Andrew Bartlett wrote:
> I've been asked to look into some bugs in our NFSv4 ACL code, and before
> I started, I wanted to have some tests to try and ensure I didn't make
> any unfortunate regressions while fixing things. 
> These patches (on master) are a starting point.  We now have a share on
> s3dc in make test that will run NFSv4 ACLs, and has raw.acls run against
> it.  Currently most (all?) if raw.acls fails, but at least it does not
> segfault, which is a really good start.
One issue right now is that the well known user SID S-1-5-11 for
"Authenticated User" which is used throughout the raw.acls tests doesn't
get mapped to a UID/GID because the DC doesn't tell us if it's a user or
group. Using a different SID or user in the raw.acls tests would help.

> Ambi:  As you have easier access to AIX and GPFS than I, can you check
> I've not missed anything in the changes to those files.  I know I've
> missed that before.

I've looked into testing these patches with GPFS.
I needed the attached changes to get it to build. But now I can set and
get ACLs just fine with the expected results.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-fix-compile-of-vfs_gpfs.c.patch
Type: text/x-patch
Size: 4780 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130415/1d3bc004/attachment.bin>

More information about the samba-technical mailing list