[PATCH] Add tests for our NFSv4 ACL code

Andrew Bartlett abartlet at samba.org
Sun Apr 14 06:00:45 MDT 2013


I've been asked to look into some bugs in our NFSv4 ACL code, and before
I started, I wanted to have some tests to try and ensure I didn't make
any unfortunate regressions while fixing things. 

These patches (on master) are a starting point.  We now have a share on
s3dc in make test that will run NFSv4 ACLs, and has raw.acls run against
it.  Currently most (all?) if raw.acls fails, but at least it does not
segfault, which is a really good start.

>From here, I want to learn more about the failures, work out at what
layer we should be doing various inheritance operations (adding
emulation if required), and possibly patch raw.acls to optionally skip
SACLs in the comparisons. 

In the future, we may wish to move more of our NFSv4 ACL handling to use
these structures, so we can (when combined with acl_xattr) hash the
NFSv4 ACL using this IDL, where we cannot obtain something like the
'backup blob' we get from GPFS. 

Please review (and in the unlikely event there are no comments, feel
free to push). 

Ambi:  As you have easier access to AIX and GPFS than I, can you check
I've not missed anything in the changes to those files.  I know I've
missed that before. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Move-nfs4acl-to-the-top-level.patch
Type: text/x-patch
Size: 4995 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-vfs-Add-vfs_handle_struct-argument-to-smb_set_nt_acl.patch
Type: text/x-patch
Size: 6148 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-vfs-Allocate-SMB4ACL_T-on-an-explict-memory-context.patch
Type: text/x-patch
Size: 11222 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-vfs-Remove-unused-security_info-argument-in-vfz_zfsa.patch
Type: text/x-patch
Size: 964 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-vfs-Fix-missing-TALLOC_CTX-argument-in-vfs_zfsacl-on.patch
Type: text/x-patch
Size: 1058 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-vfs-Add-new-VFS-module-vfs_nfs4acl_xattr-to-use-nfs4.patch
Type: text/x-patch
Size: 15216 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-librpc-Add-special-owner-group-other-constants-to-nf.patch
Type: text/x-patch
Size: 972 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-selftest-Run-raw.acls-test-against-the-nfs4acl_xattr.patch
Type: text/x-patch
Size: 3421 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130414/5f183600/attachment-0007.bin>


More information about the samba-technical mailing list