A patch to add a new Delete On Close test. Fixed after first round of reviews

Richard Sharpe realrichardsharpe at gmail.com
Fri Apr 12 21:26:31 MDT 2013

On Fri, Apr 12, 2013 at 3:55 PM, Jeremy Allison <jra at samba.org> wrote:
> On Fri, Apr 05, 2013 at 11:52:35AM -0700, Richard Sharpe wrote:
>> Hi folks,
>> I have fixed the code after the first round of reviews. If people are
>> happy, please push
> Ok, a few things before I'd push (sorry).
> I think inside test_doc_overwrite_if()
> you need to add the:
> +       /* TODO. Check it was deleted */
> check, otherwise it's really unclear
> if this should delete or not.
> Also:
> +       io.in.create_options     = 0x001060;
> should be the symbolic names, not the
> hex value (we do have these already
> defined).
> Same comments stand for the test_doc_overwrite_if_exist(),
> test_doc_create(), test_doc_create_exist() and
> test_doc_create_if_exist() tests - it would
> help if they printed a comment saying what
> they expected to happen to the file after
> the test succeeds.

Done. Hopefully I got the copyright details correct as well this time,
since I wrote all the code, although there was a lot of cut-n-paste.

Richard Sharpe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-test-that-shows-the-difference-between-Windows.patch
Type: application/octet-stream
Size: 19347 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130412/9a202655/attachment.obj>

More information about the samba-technical mailing list