A patch to add a new Delete On Close test. Fixed after first round of reviews

Jeremy Allison jra at samba.org
Fri Apr 12 16:55:54 MDT 2013

On Fri, Apr 05, 2013 at 11:52:35AM -0700, Richard Sharpe wrote:
> Hi folks,
> I have fixed the code after the first round of reviews. If people are
> happy, please push

Ok, a few things before I'd push (sorry).

I think inside test_doc_overwrite_if()
you need to add the:

+       /* TODO. Check it was deleted */

check, otherwise it's really unclear
if this should delete or not.


+       io.in.create_options     = 0x001060;

should be the symbolic names, not the
hex value (we do have these already

Same comments stand for the test_doc_overwrite_if_exist(),
test_doc_create(), test_doc_create_exist() and
test_doc_create_if_exist() tests - it would
help if they printed a comment saying what
they expected to happen to the file after
the test succeeds.



More information about the samba-technical mailing list