[patch] cifs: small variable name cleanup

Dan Carpenter dan.carpenter at oracle.com
Wed Apr 10 05:43:00 MDT 2013

server and ses->server are the same, but it's a little bit ugly that we
lock &ses->server->srv_mutex and unlock &server->srv_mutex.  It causes
a false positive in Smatch about inconsistent locking.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index edb2220..e3a0f81 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3826,7 +3826,7 @@ cifs_setup_session(const unsigned int xid, struct cifs_ses *ses,
 	if (rc) {
 		cifs_dbg(VFS, "Send error in SessSetup = %d\n", rc);
 	} else {
-		mutex_lock(&ses->server->srv_mutex);
+		mutex_lock(&server->srv_mutex);
 		if (!server->session_estab) {
 			server->session_key.response = ses->auth_key.response;
 			server->session_key.len = ses->auth_key.len;

More information about the samba-technical mailing list