[PATCH] Fix panic when running 'smbtorture smb.base'

Michael Adam obnox at samba.org
Tue Apr 9 09:28:57 MDT 2013


On 2013-04-09 at 14:58 +0200, Volker Lendecke wrote:
> On Tue, Apr 09, 2013 at 10:41:05AM +0200, Ralph Wuerthner wrote:
> > Hello list,
> > 
> > when running 'smbtorture smb.base' on a recent Samba 4 I noticed the following panic:
> > 
> > [...]
> > 
> > smb.base submits requests without any parameters and for a couple of SMB1 requests (SMBmkdir, SMBrmdir, SMBgetatr, SMBcheckpath, SMBfcloserequests) we try to access data behind req->buf+req->buflen, resulting in above panic.
> > 
> > Attached patch set adds additional checks to prevent this invalid access.
> 
> Attached with my Review. Looks good to me, thanks! Someone else?

Pushed to autobuild.

Thanks - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 206 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130409/2ef12255/attachment.pgp>


More information about the samba-technical mailing list