[SCM] CTDB repository - branch master updated - ctdb-2.1-47-g1c7adbc

Amitay Isaacs amitay at samba.org
Mon Apr 8 23:48:45 MDT 2013

On Mon, Apr 8, 2013 at 5:51 PM, Stefan (metze) Metzmacher
<metze at samba.org>wrote:

> Hi Amitay,
> >     client: Set the socket non-blocking only after connect succeeds
> >
> >     If the socket is set non-blocking before connect, then we should
> catch
> >     EAGAIN errors and retry. Instead of adding a random number of
> retries,
> >     better to wait for connect to succeed and then set the socket to
> >     non-blocking.
> >
> >     Signed-off-by: Amitay Isaacs <amitay at gmail.com>
> Why have you also moved the set_close_on_exec() call?

That's an oversight. But after thinking about it, there's no point in
setting close_on_exec, if connect() is going to fail.  So it does make
sense to set it after connect has actually succeeded.


More information about the samba-technical mailing list