[PATCH -next] CIFS: fix error return code in cifs_atomic_open()

[Steve French]

Merged into cifs-2.6.git for-next branch (for 3.10)

On Thu, Apr 4, 2013 at 12:39 PM, Jeff Layton <jlayton at redhat.com> wrote:
> On Thu, 4 Apr 2013 14:16:21 +0800
> Wei Yongjun <weiyj.lk at gmail.com> wrote:
>
>> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>>
>> Fix to return a negative error code from the error handling
>> case instead of 0, as returned elsewhere in this function.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>> ---
>>  fs/cifs/dir.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
>> index 46e455e..5699b50 100644
>> --- a/fs/cifs/dir.c
>> +++ b/fs/cifs/dir.c
>> @@ -457,8 +457,10 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry,
>>                inode, direntry->d_name.name, direntry);
>>
>>       tlink = cifs_sb_tlink(CIFS_SB(inode->i_sb));
>> -     if (IS_ERR(tlink))
>> +     if (IS_ERR(tlink)) {
>> +             rc = PTR_ERR(tlink);
>>               goto out_free_xid;
>> +     }
>>
>>       tcon = tlink_tcon(tlink);
>>       server = tcon->ses->server;
>>
>
> Looks right...
>
> Reviewed-by: Jeff Layton <jlayton at redhat.com>



-- 
Thanks,

Steve