[PATCH] Fix bug #9746 - guest ok + force user + force group doesn't work

Andrew Bartlett abartlet at samba.org
Wed Apr 3 15:28:07 MDT 2013


On Wed, 2013-04-03 at 13:47 -0700, Jeremy Allison wrote:
> When doing force user on a share, we should only
> set the guest bit if the user we're forcing to
> is the guest user.
> 
> Please review and push if you're ok with it.

Are you really sure about this?

Do we really want to elevate users from un-authenticated (guest) status
to authenticated status just because they connect to a 'force user'
share?

The smb.conf you posted in the bug as 'works for me' seems entirely
reasonable, what was the failing configuration?

Finally, if we do this, we really need a test and more comments to show
what is going on, because I can't see how it is 'obviously correct' from
the patch. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list