[PATCH] Fix bad SMB2 opcode reading in server.
jra at samba.org
Mon Apr 1 21:16:56 MDT 2013
On Mon, Apr 01, 2013 at 08:15:33PM -0700, Jeremy Allison wrote:
> Pretty obvious fix I found whilst I was working
> on the SMB2 RECVFILE code. Please review and/or
> push. We need this in 4.0.next (I'll log the
> bug tomorrow and also check over the 3.6.x
> code for the same bug).
> Thanks !
> >From 3813e926720d868ba5896620fd552d62c024d9b0 Mon Sep 17 00:00:00 2001
> From: Jeremy Allison <jra at samba.org>
> Date: Mon, 1 Apr 2013 20:11:26 -0700
> Subject: [PATCH] Fix bad SMB2 opcode reading in server.
> SMB2 opcodes are 16-bit values. We should *never*
> be reading them with IVAL(inhdr, SMB2_HDR_OPCODE),
> it shoud always be SVAL(inhdr, SMB2_HDR_OPCODE).
Gah. Feel free to fix the s/shoud/should/ in the commit
More information about the samba-technical