[Samba] [PATCH] Set RFC2307 attributes in samba-tool create

[Andrew Bartlett]

On Tue, 2012-09-25 at 16:54 +0200, Alexander Wuerstlein wrote:
> Optionally set RFC2307 (NIS Schema) attributes in samba-tool create.
> Mainly needed for UID mapping to be usable.
> Not all attributes are set-able, only harmless and non-overlapping
> ones (uid, uidNumber, gidNumber, loginShell, gecos). Description and
> homeDirectory should already be set, userPassword seems problematic.

This looks OK so far, but we really should have some test on the local
setting of idmap_ldb:use rfc2307 to avoid total user confusion.   (I
personally think that having this option creates more problems than it
solves). 

Finally, we need tests written for this and included in the testsuite,
so we don't subtly break this in the future.  (the testing of the actual
getpwnam call will be difficult, but at least the command line options
can be easily tested). 

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org