commit e1f17eef970cd8432a3391b0bb79de4857fac177 - quota waf checks

Andrew Bartlett abartlet at
Wed Sep 26 15:36:16 MDT 2012

On Wed, 2012-09-26 at 13:46 +0200, Björn JACKE wrote:
> Hi Andrew,
> I just saw you added some more quota checks to the waf tests in e1f17eef970cd.
> Some points about that, because I see some issues here: the test for
> HAVE_GETQUOTA_RSLT_GETQUOTA_RSLT_U was already there it's some lines below to
> where you added it.

Sorry about that, I clearly didn't look over the code well enough. 

>  And the test compile runs of ../tests/sysquotas.c need to
> be done with the compile flag which makes warnings be errors. I would have
> added that already but I thought it would be a good idea to first have the
> Werror_FLAGS framework being added to waf instead of just adding the gcc only
> -Werror compile flag here. We need to test the compiler support for the way we
> can make warnings throw errors. I filed bug #9158 for that.

That doesn't look too hard to do - I added a similar loop looking for
C99 flags and this would not be much different.

Thanks for your close attention to this, it is very much appreciated.

Andrew Bartlett

Andrew Bartlett                      
Authentication Developer, Samba Team 

More information about the samba-technical mailing list