Samba 3.6.6 smb2 compound command problem

[Volker Lendecke]

On Mon, Sep 24, 2012 at 08:23:15AM -0700, Herb Lewis wrote:
> On 09/24/2012 08:13 AM, Volker Lendecke wrote:
> >On Mon, Sep 24, 2012 at 08:00:11AM -0700, Herb Lewis wrote:
> >>I an seeing the following commands sent (in wireshark)
> >>
> >>SMB2 378 Create Request File: test.txt;Ioctl Request FILE_SYSTEM
> >>Function:0x0030
> >>SMB2 315 Create Response File: test.txt;Ioctl Response, Error:
> >>STATUS_FILE_CLOSED
> >>
> >>It appears the fnum returned from the create is not making it to the
> >>ioctl. I added
> >>some extra debug prints and see the following
> >>
> >>smbd_smb2_create_send: out_file_id_volatile = 38697
> >>smbd_smb2_request_process_ioctl: in_file_id_persistent =
> >>18446744073709551615 in_file_id_volatile = 18446744073709551615
> >>
> >>Where should this be getting set?
> >Isn't that possibly bug 9058?
> >
> >Volker
> >
> I don't think so. According to wireshark the ioctl is
> FSCTL_CREATE_OR_GET_OBJECT_ID
> and I don't see that mentioned in the patch for that bug. Also if I
> break in the process_ioctl
> routine and set the in_file_id_volatile to the value shown in the
> previous create_send, the
> command returns correctly.

The fact that FSCTL_CREATE_OR_GET_OBJECT_ID is not
mentioned is understandable. Look at the comment:

+                * Some SMB2 specific CtlCodes like FSCTL_DFS_GET_REFERRALS or
+                * FSCTL_PIPE_WAIT does not take a file handle.

This means that all codes explicitly listed can NOT take a
file handle. Everything NOT listed here does take a file
handle and is supposed to be handled by file_fsp_smb2.

If I read the switch statement in 3.6.8's smbd/smb2_ioctl.c
line 92ff right, for FSCTL_CREATE_OR_GET_OBJECT_ID we will
end up in the default: branch. This at least *should* fix
your problem. Can you try that if possible?

If you want me to double-check that the patchset from 9058
does indeed also apply to 3.6.6, please tell me.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de