Tidy up quota configure tests, remove pidl from autogen.sh
abartlet at samba.org
Mon Sep 3 02:15:27 MDT 2012
On Mon, 2012-09-03 at 09:25 +0200, Volker Lendecke wrote:
> On Mon, Sep 03, 2012 at 04:27:59PM +1000, Andrew Bartlett wrote:
> > Björn
> > On Sun, 2012-09-02 at 23:22 +0200, Björn Jacke wrote:
> > > The branch, master has been updated
> > > via 05f9829 waf: add new quota header checks and sysquota_4B source file
> > > via 9dd0e16 s3: remove some duplicate quota code
> > > via af5dcaa s3: adopt the new sysquotas_4B support for BSD
> > > from d392485 s3: add sysquotas_4B support
> > >
> > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > Thanks for merging those patches, it is really good to get the BSDs into
> > sysquotas, and away from the old quota code.
> > Given you have dived into the quota code, I'm wondering if you can help
> > review some more patches I have for this area?
> Please leave the pidl phase in autogen.sh. This not only
> helps the configure phase, it also greatly simplifies
> Karolin's job as a release manager. This way she can just
> tar up everything after the autogen.sh for the release.
> Without that, she would have to run configure, then run
> pidl and then manually remove everything that configure left
Fortunately the process is far more automated than that, and so there is
no need for anyone to manually add or remove anything.
You are correct to note that yes, I'm talking about not shipping the
pre-built output of pidl in the tarball. While nobody seems to have
noticed so far, the current beta releases do not include the
pre-requisites for the autoconf build.
At this point I'm the one responsible creating the new release scripts,
I'm working to redress that. The new scripts are a wrapper around 'waf
dist', and Karolin's job remains as automated at is was in the past.
Not packaging the pidl output would make my job easier, and will reduce
the tarball size. I know you have concerns about deployments where
python is just too modern, but I was hoping that by the time we release
in late 2012 that perl would be a reasonable assumption.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical